[Bug 236935] libxo =text and XOF_FLUSH does not print the first value

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Apr 2 04:11:24 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236935

--- Comment #3 from Phil Shafer <phil at freebsd.org> ---
Bug: Bad check for xo_flush_h in xo_transition:

@@ -7884,7 +7882,7 @@ xo_transition (xo_handle_t *xop, xo_xof_flags_t flags,
const char *name,

     /* Handle the flush flag */
     if (rc >= 0 && XOF_ISSET(xop, XOF_FLUSH))
-       if (xo_flush_h(xop))
+       if (xo_flush_h(xop) < 0)
            rc = -1;

     /* We have now official made output */

Only hits lines with multiple fields when flush is on, and only when certain
fields funnel data thru xo_format_value().

Turns out that xo_transition's call to xo_flush_h is not needed when it's
called from xo_do_emit_fields, so I'll add an explicit call to flush.

Thanks,
 Phil

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list