[Bug 228322] [patch] bsdinstall(8) and sade(8) lose the last block of disk in creating partition.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228322

            Bug ID: 228322
           Summary: [patch] bsdinstall(8) and sade(8) lose the last block
                    of disk in creating partition.
           Product: Base System
           Version: 11.1-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: bin
          Assignee: bugs at FreeBSD.org
          Reporter: fbsd-send-pr at natheless.net

Created attachment 193495
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193495&action=edit
diff-1: required to fix the bug / diff-2: additional could be wrong

Affected releases: 9.x, 10.x, 11.0, 11.1, 11.2-BETA1
Affected architectures: all(not verified)
Found(verified) release: 11.1
Found(verified) architecture: i386


* Description(summary)

It leads the last block to be lost that bsdintall(8)/sade(8) create a
partition(or slice) including the last block of the disk.


* Description(detail)

See attached conceptual patches rather than my bad English.

Look at the attached diff-1 for the point of this problem.

The attached diff-2 is an application to similar point.
This is not required to fix the problem, but it looks like unexpectedly working
good in wrong code...
Just for your information.

Attached diffs are for Revision 328410.


* Example step to reproduce the problem

 + Use VirtualBox.
 + Create new VM.
        type: BSD
        version: FreeBSD (32-bit)
        memory-size: 256MB
        virtual-hdd(VDI): 2.00GB
 + Set(mount) the FreeBSD-11.1-RELEASE-i386-disc1.iso to cd-drive of VM.
 + Start the VM. (boot from the iso image)
 + Do FreeBSD install
        "Partitioning": "Auto (UFS)" -> <Entire Disk> -> "MBR" -> <Finish> ->
<Commit>
 + Reboot into the installed FreeBSD.
 + Login as root.
        # /sbin/gpart list

Geom name: ada0
modified: false
state: OK
fwheads: 16
fwsectors: 63
last: 4194303
first: 63
entries: 4
scheme: MBR
Providers:
1. Name: ada0s1
   Mediasize: 2147450368 (2.0G)
   Sectorsize: 512
   Stripesize: 0
   Stripeoffset: 32768
   Mode: r2w2e3
   attrib: active
   rawtype: 165
   length: 2147450368
   offset: 32768
   type: freebsd
   index: 1
   end: 4194302
   start: 64
(snip)

 + Look at "last" @ ada0 and "end" @ ada0s1.


* Workaround:

Use gpart(8), fdisk(8) or bsdlabel(8) on runnning management.
Choose "Shell" mode for initial install and do it without bsdinstall(8) nor
sade(8).


* Attention:

Fixing(updating) bsdinstall(8) does NOT solv the partition already created by
the affected versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.