[Bug 229719] src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]: (style) Suspicious condition

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229719

            Bug ID: 229719
           Summary: src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]:
                    (style) Suspicious condition
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

Source code is

        while ((krbret = krb5_cc_next_cred(pam_context, ccache_temp,
                                &cursor, &creds) == 0)) {

Maybe better code

        while ((krbret = krb5_cc_next_cred(pam_context, ccache_temp,
                                &cursor, &creds)) == 0) {

-- 
You are receiving this mail because:
You are the assignee for the bug.