[Bug 229664] src/sys/netinet/tcp_stacks/rack.c: 2 * poor error checking ?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229664

            Bug ID: 229664
           Summary: src/sys/netinet/tcp_stacks/rack.c: 2 * poor error
                    checking ?
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

1.

src/sys/netinet/tcp_stacks/rack.c:7125]: (style) Unsigned variable 'sb_offset'
can't be negative so it is unnecessary to test it.

Source code is

        KASSERT(sb_offset >= 0, ("%s: sack block to the left of una : %d",
                    __func__, sb_offset));

if sb_offset can be negative, then using an unsigned type for it 
looks wrong. Suggest use signed type.

2.

src/sys/netinet/tcp_stacks/rack.c:7172]: (style) Unsigned variable 'sb_offset'
can't be negative so it is unnecessary to test it.

Duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.