[Bug 229663] src/sys/netinet/libalias/alias_irc.c:101: poor error checking

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229663

            Bug ID: 229663
           Summary: src/sys/netinet/libalias/alias_irc.c:101: poor error
                    checking
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

src/sys/netinet/libalias/alias_irc.c:101]: (style) Same expression on both
sides of '||'.

Source code is

        if (ah->dport == NULL || ah->dport == NULL || ah->lnk == NULL ||
            ah->maxpktsize == 0)
                return (-1);

Maybe better code

        if (ah->sport == NULL || ah->dport == NULL || ah->lnk == NULL ||
            ah->maxpktsize == 0)
                return (-1);

-- 
You are receiving this mail because:
You are the assignee for the bug.