[Bug 229548] src/sys/dev/ath/if_ath.c:2154: wierd expression ?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229548

            Bug ID: 229548
           Summary: src/sys/dev/ath/if_ath.c:2154: wierd expression ?
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

src/sys/dev/ath/if_ath.c:2154]: (error) Signed integer overflow for expression
'i<<i'.

Source code is

                for (i = 0; i < 32; i++)
                        if (ah->ah_syncstate & (i << i))

Maybe better code

                for (i = 0; i < 32; i++)
                        if (ah->ah_syncstate & (1 << i))

-- 
You are receiving this mail because:
You are the assignee for the bug.