[Bug 225771] [icmp] members of icmpstat are still u_long, why not uint64_t?

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Feb 8 20:39:48 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225771

            Bug ID: 225771
           Summary: [icmp] members of icmpstat are still u_long, why not
                    uint64_t?
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: kxie at xiplink.com

Created attachment 190441
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190441&action=edit
replace u_long to uint64_t in icmpstat

r253081 changed all fields of many stat structures to uint64_t to adapt with
the PCPU counters, but icmpstat's all fields are still u_long. And then r253084
migrate many structs including icmpstat to PCPU.

There is no error while building it because the number of the fields is even,
so it might be forgotten, but if a new u_long field is added into the struct,
then there will be an build error.

A patch to change all fields to uint64_t is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list