[Bug 222685] [PATCH] "make packagekernel" not checking MK_DEBUG_FILES

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222685

            Bug ID: 222685
           Summary: [PATCH] "make packagekernel" not checking
                    MK_DEBUG_FILES
           Product: Base System
           Version: 11.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: egypcio at googlemail.com
          Keywords: patch

Created attachment 186799
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=186799&action=edit
[PATCH] "make packagekernel" not checking MK_DEBUG_FILES

following the behavior of previous checks on DEBUG_DISTRIBUTIONS=, if one has
MK_DEBUG_FILES=no in the /etc/make.conf a "make packagekernel" should not
create any -dbg.txz tarball for KERNCONF (even with extra kernels listed).

how to reproduce? checkout stable/11 branch's src, cd to its dir and play;

    # svnlite info
    Path: .
    Working Copy Root Path: /usr/src
    URL: svn://svn.freebsd.org/base/stable/11
    Relative URL: ^/stable/11
    Repository Root: svn://svn.freebsd.org/base
    Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
    Revision: 324100
    Node Kind: directory
    Schedule: normal
    Last Changed Author: markj
    Last Changed Rev: 324085
    Last Changed Date: 2017-09-28 15:23:38 +0000 (Thu, 28 Sep 2017)

    # mkdir /dist
    # make -s buildworld
    # make -s buildkernel
    # make -s distributeworld DISTDIR=/dist
    # make -s distributekernel DISTDIR=/dist
    # make -s packageworld DISTDIR=/dist
    # make -s packagekernel DISTDIR=/dist

doing so, will present you with all -dbg.txz under /dist.

remove all *.txz files you created, set MK_DEBUG_FILES=no and rerun
"packageworld" and "packagekernel"; you will still get kernel-dbg.txz...

    # make -s packageworld DISTDIR=/dist MK_DEBUG_FILES=no
    # make -s packagekernel DISTDIR=/dist MK_DEBUG_FILES=no

apply the suggested patch, and do it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.