[Bug 222620] [patch] usr.sbin/ppp/auth.c: Incorrect NOPAM section in auth_CheckPasswd

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Sep 26 11:13:21 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222620

            Bug ID: 222620
           Summary: [patch] usr.sbin/ppp/auth.c: Incorrect NOPAM section
                    in auth_CheckPasswd
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: bouceklubos at gmail.com
          Keywords: patch

Created attachment 186736
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=186736&action=edit
auth.c patch

Hello,

In my opinion, the current code in usr.sbin/ppp/auth.c:auth_CheckPasswd (NOPAM
section) is incorrect:

- pw is not initialized before use,
- success is returned if crypt(3) returns error (NULL).

I'm attaching a patch, please review.

Regards,

Lubos Boucek

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list