[Bug 223876] [PATCH] swapinfo/pstat -s alignment is broken with swap on zvols and long paths

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223876

            Bug ID: 223876
           Summary: [PATCH] swapinfo/pstat -s alignment is broken with
                    swap on zvols and long paths
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: ciml at nuxi.ca
          Keywords: patch

Created attachment 188289
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188289&action=edit
mentioned diff

Hi,

After using pstat(8) to see what my zvol swap looked like, the output was like
this:

Device          1K-blocks     Used    Avail Capacity
/dev/zvol/rpool/swap   8388608        0  8388608     0%
/dev/md99            4000        0     4000     0%
Total             8392608        0  8392608     0%

I was a bit annoyed. I decided to simply align them to a total of 72 chars.
I think it's plenty for file names, and it made the output closer to what I
expected.

Device                  1K-blocks         Used        Avail     Capacity
/dev/zvol/rpool/swap      8388608            0      8388608           0%
/dev/md99                    4000            0         4000           0%
Total                     8392608            0      8392608           0%

It might not be the most flexible solution, but I personally think it's plenty,
as filenames directing to swap usually wouldn't be much longer than this.

Attached is a proposed diff. I also took the liberty of fixing a few style
bugs.
Namely, static flags being explicitly initialized to 0 while others weren't,
although they were all tested, and a flag being set to 1 with ++var instead
of using var = 1 as with all the others.

Good day.

-- 
You are receiving this mail because:
You are the assignee for the bug.