[Bug 192528] pwd_mkdb fails if /etc/shells contains duplicates

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri May 12 03:32:27 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192528

--- Comment #7 from Kyle Evans <bsdports at kyle-evans.net> ---
Hi,

I've created the following review for this: https://reviews.freebsd.org/D10690

memset()'ing the line isn't necessary every iteration since fgets() should just
overwrite as necessary and null-terminate properly. I've also hit the second
case where a line ends in a comment or with no valid shell.

Cheers,

Kyle Evans

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list