[Bug 218993] [patch] [ipfw] ipfw(8) may fail to remove rules

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218993

            Bug ID: 218993
           Summary: [patch] [ipfw] ipfw(8) may fail to remove rules
           Product: Base System
           Version: 11.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: eugen at freebsd.org
          Keywords: patch

Created attachment 182222
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182222&action=edit
clean structures before reusing

Let's try this in a shell:

# n=32
# for i in $(jot $n 1); do
> ipfw -q add 1 count ip from any to any
> ipfw -q add 2 count ip from any to any
> done
# ipfw delete 1 2
ipfw: rule 2: setsockopt(IP_FW_XDEL): Invalid argument

Rules numbered 1 got deleted, rules numbered 2 do not.
Note that problem does not manifest if n<32.

A bug is in /sbin/ipfw's ipfw_delete() function that fails to clean "rt"
structure before each iteration. ipfw_zero() function has similar problem.

Attached patch fixes this.

-- 
You are receiving this mail because:
You are the assignee for the bug.