[Bug 217667] arp "moved" log message gives incorrect "from" MAC

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217667

            Bug ID: 217667
           Summary: arp "moved" log message gives incorrect "from" MAC
           Product: Base System
           Version: 11.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: andrew at tao11.riddles.org.uk

The ARP "x moved from y to z" log message in if_ether.c is mistakenly taking
the address of the char* which points to the previous MAC address, rather than
taking the pointer value; thus the reported former MAC address is garbage.

For example these two messages were the result of swapping a device out and
then back (actual IP redacted):

kernel: arp: x.x.x.x moved from 18:8d:69:c6:00:00 to 14:cc:20:09:a6:50 on
ue0.10
kernel: arp: x.x.x.x moved from 18:8d:69:c6:00:00 to 00:26:44:17:90:e1 on
ue0.10

ll_addr is a char*, not a char[], so:

  (u_char *)&la->ll_addr

should be

  (u_char *)la->ll_addr

-- 
You are receiving this mail because:
You are the assignee for the bug.