[Bug 217602] It is desirable that dot files grow recursive functionality in pw, bsdinstall, etc

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217602

            Bug ID: 217602
           Summary: It is desirable that dot files grow recursive
                    functionality in pw, bsdinstall, etc
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: imp at FreeBSD.org

As discussed on IRC with imp, Allan Jude, John Baldwin, and myself...

bsdconfig mirrors the actions of pw(8) with respect to skel (please see the
pw(8) manual with respect to skeleton files and the effect the `-m' parameter
has on copying of skel files).

At the very least, the suggested change here has to be accompanied by a
corresponding change to several other tools, including but not limited to
pw(8), adduser(8), and their respective manuals.

A patch that implements the bsdinstall part of the change can be found at
https://github.com/freebsd/freebsd/pull/98 and it still applies, included
inline for your convenience since it is so simple. Also noted in the code
review the -R -n should be -Rn (or maybe that was in the IRC conversation).

Since this isn't a code snippet ready to commit, redirecting to bugzilla per
project policy. This should be assigned to dteske at .

usr.sbin/bsdconfig/usermgmt/share/user.subr
 @@ -145,12 +145,12 @@ f_user_copy_dotfiles()
                [ -e "$file" ] || continue # no-match

                f_shell_escape "$file" "_file"
 -              f_eval_catch $funcname cp "cp -n '%s' '%s'" \
 +              f_eval_catch $funcname cp "cp -R -n '%s' '%s'" \
                        "$_file" "$_user_home_dir/${_file#dot}"
                retval=$?
                [ $retval -eq $SUCCESS ] || break
                f_eval_catch $funcname chown \
 -                      "chown -h '%i:%i' '%s'" \
 +                      "chown -R -h '%i:%i' '%s'" \
                        "$_user_uid" "$_user_gid" \
                        "$_user_home_dir/${_file#dot}"
                retval=$?

-- 
You are receiving this mail because:
You are the assignee for the bug.