[Bug 220023] procstat -L only works with corefiles; documentation/code could be tweaked for usability/clarity

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220023

Ngie Cooper <ngie at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-bugs at FreeBSD.org    |ngie at FreeBSD.org
             Status|New                         |Open
            Summary|procstat -L only works with |procstat -L only works with
                   |corefiles ...?              |corefiles;
                   |                            |documentation/code could be
                   |                            |tweaked for
                   |                            |usability/clarity

--- Comment #2 from Ngie Cooper <ngie at FreeBSD.org> ---
Porting over internal bugzilla comments for context and taking the bug:

[reply] [-] Comment 2 Ngie "Hakuna Matata" Cooper 2017-06-26 18:31:03 PDT

I'll just fix the documentation since it doesn't state that it should or
shouldn't do that, which is a bug.

[reply] [-] Comment 3 Conrad Meyer 2017-06-26 18:38:45 PDT

I mean, it does say that already:

     -L      Display LWP info for the process pertaining to its signal driven
             exit.
             ^^^^                                               ^^^^^^^^^^^^^

[reply] [-] Comment 4 Ngie "Hakuna Matata" Cooper 2017-06-26 18:51:08 PDT

(In reply to comment #3)
> I mean, it does say that already:
> 
>      -L      Display LWP info for the process pertaining to its signal driven
>              exit.
>              ^^^^                                               ^^^^^^^^^^^^^

It's implied, but in a bit of a roundabout way as you noted. Also, the synopsis
suggests that it should be able to take either a pid or a corefile. From
https://www.freebsd.org/cgi/man.cgi?query=procstat&apropos=0&sektion=0&manpath=FreeBSD+12-current&arch=default&format=html
:

...

     procstat [--libxo] [-CHhn] [-w interval]
              [-b | -c | -e | -f | -i | -j | -k | -l | -L | -r | -s | -S | -t |
-v | -x]
              [-a | pid | core ...]

...

Furthermore, if it's only meant to work with a corefile, the error message I
reported in the upstream bug could be clarified by returning the error from
kvm_open2, or something similar to that.

With mjohnston clarifying the use upstream and after reviewing things a bit
more, this is a Trivial item and not a Normal item.

What triggered this bug was the fact that I was trying to write tests/manually
test out the functionality, and because the documentation wasn't 100% clear, I
filed this bug and committed a few changes upstream to try and help clarify the
feature as best I could. This was one of the areas that wasn't clear to me that
I figured warranted more discussion.

-- 
You are receiving this mail because:
You are the assignee for the bug.