[Bug 221084] Loader fails to boot from vanilla ZFS version 28 pools (regression caused by MFC of r314112)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221084

            Bug ID: 221084
           Summary: Loader fails to boot from vanilla ZFS version 28 pools
                    (regression caused by MFC of r314112)
           Product: Base System
           Version: 11.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: regression
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: fk at fabiankeil.de
                CC: mav at FreeBSD.org, tsoome at me.com

Created attachment 184823
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184823&action=edit
loader: Ignore check_mos_features()'s return code but log it

After updating a system based on r321478 to one based on r321624
the loader rejected vanilla ZFS version 28 pools with the message:

   ZFS: pool bpool is not supported

Pools that have been upgraded to contain features are accepted as expected.

The offending commits seems to be r321525 + r321526 (which MFC'd r314112).

For now I'm using the attached patch which works around the problem by
ignoring the check_mos_features() return code.

When using vanilla ZFS version 28 pools it results in the loader message:

   ZFS: check_mos_features() returned 2 for pool bpool. Continuing

Probably  check_mos_features() should only be called when features are present.

I ran into the problem using bhyveload which relies on /boot/userboot.so.
While I expect the problem to be reproducible with the other loaders as well,
I haven't verified this.

-- 
You are receiving this mail because:
You are the assignee for the bug.