[Bug 221059] release: scripts/mk-vmimage.sh does not fail on error

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221059

            Bug ID: 221059
           Summary: release: scripts/mk-vmimage.sh does not fail on error
           Product: Base System
           Version: 10.3-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: xmj at FreeBSD.org

I'm currently trying to build AMI images, and I've noticed that one of the
components of release behaves interestingly:

During `make ec2ami` (more specifically, the cw-ec2 target) Makefile calls out
to scripts/mk-vmimage.sh. This script in turn sources its functions from
tools/vmimage.subr.

However, if for instance an error is obtained during the `vm_copy_base` phase,
the script will continue as if nothing happens, and even end with a return
value of 0.

In my case, while trying to copy the "old" image's contents to the "new" image,
the file-backed memorydisk was set to 5000M (too small for the packages I added
in).

No step in mk-vmimage.sh will actually fail -- especially not the
`vm_copy_base` step -- and the new system will end up missing arbitrary files.

Steps to reproduce:

1. in ${EC2CONF}, Set a VMSIZE that is too small to host the base system and
all extra packages.

2. make WITH_CLOUDWARE=yes [...] ec2ami

-- 
You are receiving this mail because:
You are the assignee for the bug.