[Bug 220698] [iflib][em] some interface options flags can not change

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220698

            Bug ID: 220698
           Summary: [iflib][em] some interface options flags can not
                    change
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: kaho at elam.kais.kyoto-u.ac.jp

Created attachment 184318
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184318&action=edit
iflib.c cleanup

The options flags VLAN_HWCSUM on if_em driver can not be changed by using
ifconfig command.
See https://lists.freebsd.org/pipermail/freebsd-net/2017-May/048008.html
The WOL_UCAST flags can't also be changed.

The attached patch makes these flags changeable. And it contains others listing
below.

1. WOL related flags can be changed without re-initialize.

2. Because of the function if_vlancap() refers the parent device flags,
I think, if_togglecapenable() is first, then if_vlancap() is next.

3. Don't check immediate number but defined value.
I don't have any problems now and it is not related to options flags,
but I think it is incorrect.

-- 
You are receiving this mail because:
You are the assignee for the bug.