[Bug 216514] rpcgen leaves broken output file if ${CPP} not found

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216514

            Bug ID: 216514
           Summary: rpcgen leaves broken output file if ${CPP} not found
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: emaste at freebsd.org

As a result of a misconfigured external toolchain I ended up with ${CPP} set to
a nonexistent file. In this case rpcgen creates a broken output file before
exiting with an error, and subsequent builds do not try to rebuild it.

rpcgen should either not create the output file early (e.g., by writing to a
temporary and renaming on success), or delete it on error.

(Root cause of this issue was an old, mismatched mips64-xtoolchain-gcc.)

Reproduction steps:
% touch foo.h
% RPCGEN_CPP=does-not-exist rpcgen -C -h foo.h -o foo.out
rpcgen: execvp does-not-exist: No such file or directory
% echo $?
1
% ls -l foo.out
-rw-r--r--  1 emaste  emaste  240 26 Jan 21:52 foo.out

-- 
You are receiving this mail because:
You are the assignee for the bug.