[Bug 198377] libc: Invalid size check in load_msgcat()

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198377

Conrad Meyer <cem at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cem at freebsd.org

--- Comment #3 from Conrad Meyer <cem at freebsd.org> ---
This Coverity warning is sort of dubious.  It's true on our 64-bit
architectures, where sizeof(size_t) == sizeof(off_t); but it's not true on our
32-bit architectures, where size_t is half as big.

I think we should just ignore the CID in Coverity and move on.

It would be a pretty major OS bug for st_size to ever be negative, so I don't
like the proposed patch.  If you want to add a KASSERT to sys_stat or kern_stat
that st_size is >= 0, I would support that instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.