[Bug 215747] [patch] kldstat: align hex sizes to the right

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215747

            Bug ID: 215747
           Summary: [patch] kldstat: align hex sizes to the right
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: grunk at pestilenz.org
          Keywords: patch

kldstat(1) outputs something like

$ kldstat
Id Refs Address            Size     Name
 1   16 0xffffffff80200000 1fa7c38  kernel
 2    1 0xffffffff82221000 3710     ums.ko
 3    1 0xffffffff82225000 1fe5a3   zfs.ko
 4    1 0xffffffff82424000 811f     opensolaris.ko
 5    1 0xffffffff8242d000 10582    geom_eli.ko

I can not see the advantage of the "Size" column being aligned to the left, but
maybe I am missing something.  As the code shows, the minus in the "%-8zx"
modifier seems to have been entered on some purpose.

However, I would think of an output like this to be more useful:

$ ./kldstat
Id Refs Address            Size     Name
 1   16 0xffffffff80200000  1fa7c38 kernel
 2    1 0xffffffff82221000     3710 ums.ko
 3    1 0xffffffff82225000   1fe5a3 zfs.ko
 4    1 0xffffffff82424000     811f opensolaris.ko
 5    1 0xffffffff8242d000    10582 geom_eli.ko

If this makes sense to you, please profit from the following simple patch.
If not, I am sorry for the noise, and would be grateful for an explanation why
left-aligned is more helpful to the user.

Index: kldstat.c
===================================================================
--- kldstat.c   (revision 310867)
+++ kldstat.c   (working copy)
@@ -78,7 +78,7 @@
               printf("%2d %4d %p %5s %s",
                   stat.id, stat.refs, stat.address, buf, stat.name);
        } else {
-               printf("%2d %4d %p %-8zx %s",
+               printf("%2d %4d %p %8zx %s",
                    stat.id, stat.refs, stat.address, stat.size, stat.name);
        }
     }

-- 
You are receiving this mail because:
You are the assignee for the bug.