[Bug 217260] [kbdmux] fails to compile with LINT on ^/stable/10

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217260

Li-Wen Hsu <lwhsu at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdrewery at FreeBSD.org

--- Comment #1 from Li-Wen Hsu <lwhsu at FreeBSD.org> ---
We had discussed this earlier, I cut off a section and paste here:

> /workspace/src/sys/modules/kbdmux/../../dev/kbdmux/kbdmux.c:411:26: error: use of undeclared identifier 'key_map'; did you mean 'keymap'?
>                 keymap = malloc(sizeof(key_map), M_KBDMUX, M_NOWAIT);
>                                        ^~~~~~~
>                                        keymap

The error here is what happens when the header, kbdmuxmap.h, is empty.
Note the error was not "no such file", but rather missing structures.  I
hit this issue when I added options KBDMUX_DFLT_KEYMAP to my kernel
config but did not set a value for it.

I see this was added by Ed in r297685.

I'm guessing somehow the LINT build is not specifying a default value
for KBDMUX_DFLT_KEYMAP...

When I go into sys/amd64/conf and run 'make LINT' I do get
KBDMUX_DFLT_KEYMAP=it.iso in the LINT file.

> kbdmuxmap.h:
>         kbdcontrol -P ${S:S/sys$/share/}/vt/keymaps -P ${S:S/sys$/share/}/syscons/keymaps -L ${KBDMUX_DFLT_KEYMAP} | sed -e 's/^static keymap_t.* = /static keymap_t key_map = /' -e 's/^static accentmap_t.* = /static accentmap_t accent_map = /' > kbdmuxmap.h

Perhaps this is failing and not creating a proper header file.

> I have some new discovery, originally I built -CURRENT LINT on 10.3-R,
> it failed no matter what parallelism or not.  Then I change environment to
> 11.0-BETA1 and it builds successfully, with or without parallelism:

Does the 10.0 kbdcontrol support the -P/-L flags to generate this
header?  It may just need to be added as a build tool.

-- 
You are receiving this mail because:
You are the assignee for the bug.