[Bug 217221] contrib/libpcap installs internal header files in /usr/include

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217221

            Bug ID: 217221
           Summary: contrib/libpcap installs internal header files in
                    /usr/include
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: woodsb02 at freebsd.org

contrib/libpcap installs *libpcap-internal* header files, pcap-int.h, as a
system header file in /usr/include.

This does not discourage programmers from including pcap-int.h and potentially
depending on internals that are not only subject to change from release to
release but that have changed *quite* a bit over time.

That header file pcap-int.h has in fact changed to include another
*libpcap-internal* header file, portability.h, which is not installed by
contrib/libpcap. The result is that any programs which do include pcap-int.h
will now fail to build as they cannot find portability.h.
https://github.com/the-tcpdump-group/libpcap/commit/7cc3ed6dd1a3389fc64f0d2f7832dff4a5f05bcb

This was discovered by the port sysutils/pftop includes pcap-int.h, and now
fails to build since the import of libpcap 1.8.1 in this commit:
https://svnweb.freebsd.org/base?view=revision&revision=313695

-- 
You are receiving this mail because:
You are the assignee for the bug.