[Bug 224498] ls -lh dose not display properly around 1MB, 1GB, ...

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224498

--- Comment #3 from Pawel Biernacki <pawel.biernacki at gmail.com> ---
Please see https://reviews.freebsd.org/D13578 for proposed patch.

Issue was caused by the way the final value was calculated in snprintf call,
where remainder and divisor/2 was added back to the divided number. If
remainder + divisor/2 was larger than 1024, it added 1 to the final value. If
the final value as already 999 (as in the example reported), that brought it to
1000. If the buffer length provided was 4 (as is the case with ls), that left
no space for the unit character. 
Same issue was also present for other numbers if too small buffer lengths where
used.

The fix continues the division of the original number if the above case happens
-- added the appropriate check to the for loop performing the division. This
lowers the value shown, to make it fit into the buffer space provided (1.0M for
4 character buffer, as used by ls).

-- 
You are receiving this mail because:
You are the assignee for the bug.