[Bug 210537] [patch] [feature request] set MIME type in cron-generated e-mails

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210537

Eugene Grosbein <eugen at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress

--- Comment #16 from Eugene Grosbein <eugen at freebsd.org> ---
(In reply to Mikhail T. from comment #15)

It still does not respect WITHOUT_FILE.

And if such code uses openssl, it should depend on WITHOUT_OPENSSL too.
However, our libc actually has b64_ntop() function for base64 encoding provided
with <resolv.h> header and you can get example of its usage from
src/usr.bin/uuencode/uuencode.c

"usage" message mistakenly shows "-m" instead of "-M".
Added #include's should be sorted by name of header.

sizeof(char) is 1 by definition of C programming language (see
http://chimera.roma1.infn.it/SP/COMMON/iso-iec-9899-1990.pdf section 6.5.3.4
paragraph 4), so you need not use bufsize*sizeof(char).

With MAGIC_MIME flag to magic_open() you request both of MIME type and encoding
but then skip MIME type with strstr() looking for encoding only. Wouldn't it
better to use MAGIC_MIME_ENCODING instead of MAGIC_MIME and directly compare
result with "charset=binary"?

Otherwise, looks good, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.