[Bug 224069] (Fix included) Use of uninitalized register value in vesa.ko, causing X, text console and suspend/resume to fail

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Dec 4 00:43:52 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224069

Mark Linimon <linimon at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linimon at FreeBSD.org

--- Comment #1 from Mark Linimon <linimon at FreeBSD.org> ---
(In reply to Stefan B. from comment #0)
> Thus I wish I knew who has commented out that line for what reason.

(Note: jkim is already on the Cc: here, so I don't need to take any action.)

fwiw, there's a way to look that up.

Look up the src file on FreeBSD's svnweb:

  https://svnweb.freebsd.org/base/head/sys/dev/fb/vesa.c

Do an "annotate" based on the latest commit, here rev 326255:

  https://svnweb.freebsd.org/base/head/sys/dev/fb/vesa.c?annotate=326255

Search for the commented out line (shows as 517 there rather than 515):

  https://svnweb.freebsd.org/base/head/sys/dev/fb/vesa.c?annotate=326255#l517

Clicking the line number in that block takes you to:

  https://svnweb.freebsd.org/base/head/sys/dev/fb/vesa.c?r1=198250&r2=198251&

Clicking the 'latest revision' link on the right takes you to:

 
https://svnweb.freebsd.org/base/head/sys/dev/fb/vesa.c?revision=198251&view=markup

which is a very large commit from jkim Mon Oct 19 20:58:10 2009 UTC (8 years, 1
month ago).  I have no knowledge of what's all involved there.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list