[Bug 220698] [iflib][em] some interface options flags can not change

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Aug 25 06:15:29 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220698

--- Comment #1 from Kaho Toshikazu <kaho at elam.kais.kyoto-u.ac.jp> ---
Created attachment 185741
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185741&action=edit
make vlan_hwcsum and wol flags changeable

This patch makes only vlan_hwcsum and wol flags changeable.

1st chunk:
I think that IFCAP_FLAGS defines changeable flags in general.
In if.h, IFCAP_RXCSUM_IPV6 | IFCAP_TXCSUM_IPV6 is IFCAP_HWCSUM_IPV6,
and IFCAP_TSO4 | IFCAP_TSO6 is IFCAP_TSO. Change these flags for simplifying.
Add missing flags IFCAP_WOL_MCAST (contained by IFCAP_WOL) and
IFCAP_VLAN_HWCSUM.
IFCAP_HWSTATS should be removed because it is not changeable flags,
but it stays in the patch now.

2nd chunk:
Change from (IFCAP_TOE4 | IFCAP_TOE6) to IFCAP_TOE defined in if.h.
Delete WOL related lines. "setmask |= (mask & IFCAP_FLAGS);" has
same functionality, if IFCAP_FLAGS has IFCAP_WOL added by 1st chunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list