[Bug 218889] top show CPU states header in batch mode

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218889

            Bug ID: 218889
           Summary: top show CPU states header in batch mode
           Product: Base System
           Version: 11.0-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: reed at reedmedia.net

(The component field here in bugzilla doesn't have "contrib" so I chose "bin".)

I don't know history of why the dostates toggle is there to not show the CPU:
states "the first time".  But this makes it so the batch view (like piped top
to a file) excludes the CPU states and just has a blank line there.

Here is a simple fix (but maybe fix comment). Or maybe just get rid of
"dostates".

Index: contrib/top/top.c
===================================================================
--- contrib/top/top.c   (revision 317435)
+++ contrib/top/top.c   (working copy)
@@ -637,7 +637,7 @@
                        system_info.procstates);

        /* display the cpu state percentage breakdown */
-       if (dostates)   /* but not the first time */
+       if ((!interactive) || (dostates))       /* but not the first time */
        {
            (*d_cpustates)(system_info.cpustates);
        }

(I originally saw this problem with pfSense's System Activity page while
authoring a book about it.)

-- 
You are receiving this mail because:
You are the assignee for the bug.