[Bug 194823] "bsdgrep -E { /dev/null" core dumps

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Apr 21 14:36:24 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194823

--- Comment #7 from commit-hook at freebsd.org ---
A commit references this bug:

Author: emaste
Date: Fri Apr 21 14:36:10 UTC 2017
New revision: 317254
URL: https://svnweb.freebsd.org/changeset/base/317254

Log:
  bsdgrep: add BSD_GREP_FASTMATCH knob for built-in fastmatch

  Bugs have been found in the fastmatch implementation as used in bsdgrep.
  Some have been fixed (r316495) while fixes for others are in review
  (D10098).

  In comparison with the fastmatch implementation, Kyle Evans found that:

  - regex(3)'s performance with literal expressions offers a speed
    improvement over fastmatch

  - regex(3)'s performance, both with simple BREs and EREs, seems to be
    comparable

  The regex implementation was imported in r226035, and the commit message
  reports:

      This is a temporary solution until the whole regex library is
      not replaced so that BSD grep development can continue and the
      backported code gets some review and testing. This change only
      improves scalability slightly, there is no big performance boost
      yet but several minor bugs have been found and fixed.

  Introduce a WITH_/WITHOUT_BSD_GREP_FASTMATCH knob to support testing
  of both approaches.

  PR:           175314, 194823
  Submitted by: Kyle Evans <kevans91 at ksu.edu>
  Reviewed by:  bdrewery (in part)
  Differential Revision:        https://reviews.freebsd.org/D10282

Changes:
  head/share/man/man5/src.conf.5
  head/share/mk/src.opts.mk
  head/tools/build/options/WITHOUT_BSD_GREP_FASTMATCH
  head/usr.bin/grep/Makefile
  head/usr.bin/grep/grep.c
  head/usr.bin/grep/grep.h
  head/usr.bin/grep/util.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list