[Bug 218592] [patch] fsck_ffs(8): incorrect bounds check in preen mode when softdep is enabled
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Fri Apr 14 15:22:24 UTC 2017
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218592
--- Comment #4 from commit-hook at freebsd.org ---
A commit references this bug:
Author: kib
Date: Fri Apr 14 15:22:01 UTC 2017
New revision: 316852
URL: https://svnweb.freebsd.org/changeset/base/316852
Log:
In fsck_ffs pass1, prevent the inosused variable from wrapping.
The loop that scans the used inode map when soft updates is in use
assumes that the inosused variable is signed. However, ino_t is
unsigned, so the loop invariant is incorrect and the check for
inosused wrapping to < 0 can never be true.
Instead of checking for wrap after the fact just prevent it from
happening in the first place.
PR: 218592
Submitted by: Todd Miller <todd.miller at courtesan.com>
Reviewed by: mckusick
MFC after: 1 week
Changes:
head/sbin/fsck_ffs/pass1.c
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-bugs
mailing list