Fix cp not to give chflags error on NFS

Lewis Donzis lew at perftech.com
Sat Apr 1 16:08:30 UTC 2017


It's fairly annoying that cp has no way to suppress the chflags error when the destination file is on an NFS mount.  A bigger problem than the error message is that it returns exit status 1, which causes things like make to fail when there really was no error.

What do you think about the following change to /usr/src/bin/cp/utils.c:

398c398
<               if (fdval ?
---
>               if ((fdval ?
401c401
<                   chflags(to.p_path, fs->st_flags))) {
---
>                   chflags(to.p_path, fs->st_flags))) && errno != ENOTSUP) {

which simply ignores the error if the destination filesystem doesn't support chflags?

Thanks,
lew



More information about the freebsd-bugs mailing list