[Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823

Kirk McKusick <mckusick at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mckusick at FreeBSD.org

--- Comment #7 from Kirk McKusick <mckusick at FreeBSD.org> ---
Given that your value of cgp->cg_old_niblk is > 2^15 says that at least under
OpenBSD the declaration of cgp->cg_old_niblk as int16_t is wrong. Rather it
should be declared as uint16_t. So it seems to me that the correct solution
here is to change the declaration of cgp->cg_old_niblk to be uint16_t as it
should. This change should not break any existing filesystems.

As to the question of compatibility of OpenBSD's UFS to that of FreeBSD, we
have managed to do that so far. So, I am in favor of keeping them compatible
(at least for small changes such as this one).

-- 
You are receiving this mail because:
You are the assignee for the bug.