[Bug 213845] [PATCH] bxe(4) boots with no capabilities enabled

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213845

            Bug ID: 213845
           Summary: [PATCH] bxe(4) boots with no capabilities enabled
           Product: Base System
           Version: 11.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: pherman at frenchfries.net
          Keywords: patch

bxe cards boot with no hardware capabilities (i.e.
RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4...) enabled.
"ifconfig -m bxe0" correctly displays what NIC is capable of, but no options
are enabled.

This is a problem because, for example, "ifconfig vlanmtu" is not allowed to be
changed by the driver and consequently all cloned vlan devices end up with an
MTU of 1496 by default.  The bug was introduced when the driver was updated to
use if_setcapabilities().

CURRENT is also affected. 10 isn't. Suggested patch against 11.0-STABLE below.

bxe0: <QLogic NetXtreme II BCM57810 10GbE (B0) BXE v:1.78.89

FreeBSD rt2-gerdc1.cgn.cleverbridge.com 11.0-STABLE FreeBSD 11.0-STABLE #1
r308000M: Thu Oct 27 17:29:07 CEST 2016    
root at rt2-gerdc1.cgn.cleverbridge.com:/usr/obj/usr/src/sys/rt2-gerdc1  amd64


Index: sys/dev/bxe/bxe.c
===================================================================
--- sys/dev/bxe/bxe.c   (revision 308000)
+++ sys/dev/bxe/bxe.c   (working copy)
@@ -12691,6 +12691,7 @@
          IFCAP_WOL_MAGIC);
 #endif
     if_setcapabilitiesbit(ifp, capabilities, 0); /* XXX */
+    if_setcapenable(ifp, if_getcapabilities(ifp));
     if_setbaudrate(ifp, IF_Gbps(10));
 /* XXX */
     if_setsendqlen(ifp, sc->tx_ring_size);

-- 
You are receiving this mail because:
You are the assignee for the bug.