[Bug 214832] if_pflog subrulenr incorrectly set

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Nov 25 21:24:06 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214832

            Bug ID: 214832
           Summary: if_pflog subrulenr incorrectly set
           Product: Base System
           Version: 11.0-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: andywhite at gmail.com

https://svnweb.freebsd.org/base/releng/11.0/sys/netpfil/pf/if_pflog.c?view=markup#l224

should set subrulenr to -1, not to 1, when there is no subrule

i.e.

hdr.subrulenr =  -1;

NOT

hdr.subrulenr =  1;

This is used in tcpdump 

https://svnweb.freebsd.org/base/releng/11.0/contrib/tcpdump/print-pflog.c?view=markup#l94

to determine there is no subrule and to format output differently.

without this change, you will get output like

rule 0..16777216(match) , instead of the correct output of
rule 0/0(match)

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list