[Bug 209270] [igmp] logic error in igmp_v3_suppress_group_record

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209270

            Bug ID: 209270
           Summary: [igmp] logic error in igmp_v3_suppress_group_record
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: turingsboy at yahoo.com

In igmp_v2_suppress_group_record, I see the following:

        if (inm->inm_state != IGMP_G_QUERY_PENDING_MEMBER ||
            inm->inm_state != IGMP_SG_QUERY_PENDING_MEMBER)
                return;

This is always true due to the logical OR.

It looks like it should be this:

        if (inm->inm_state != IGMP_G_QUERY_PENDING_MEMBER &&
            inm->inm_state != IGMP_SG_QUERY_PENDING_MEMBER)
                return;

I do not know the affect of the change, but the code as written looks 
very suspiciously like a programming error.

-- 
You are receiving this mail because:
You are the assignee for the bug.