[Bug 207916] [PATCH] etc/rc.d/netwait breaks on releng/10.3 if ipfw configured

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207916

            Bug ID: 207916
           Summary: [PATCH] etc/rc.d/netwait breaks on releng/10.3 if ipfw
                    configured
           Product: Base System
           Version: 10.3-BETA2
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: John.Marshall at riverwillow.com.au
          Keywords: patch

Created attachment 168033
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168033&action=edit
Add ipfw to REQUIRE in /etc/rc.d/netwait

FreeBSD rwsrv04.gfn.riverwillow.net.au 10.3-RC2 FreeBSD 10.3-RC2 #0 r296673:
Sat Mar 12 11:12:32 AEDT 2016    
root at rwsrv04.gfn.riverwillow.net.au:/build/obj/build/src/sys/RWSRV04  i386

In Kernel config file:
options         IPFIREWALL              #firewall

In rc.conf:
netwait_enable=YES

All was well in 10.2-RELEASE, but now...

/etc/rc.d/netwait no longer succeeds in pinging ${netwait_ip} because the
firewall has not yet been started and the default "deny all" condition
prevails. netwait times out, startup proceeds and bits of networking components
don't get started because the interfaces haven't finished being configured yet
(now that packets can get through).

The attached patch makes netwait dependent on ipfw. I doubt that this is the
proper solution but "it works for me". netwait used to be dependent on
NETWORKING and everything worked fine. The commit message for r294680 explains
why NETWORKING was removed from the netwait REQUIRE list but there are more
things that need to be taken into account. Replacing NETWORKING with only devd
and routing in the REQUIRE list is obviously insufficient. I'm thinking the
dependency probably belongs in a different script - but where?

The effect of adding ipfw to the netwait REQUIRE list changes rcorder like
this:

--- rcorder.10.3        2016-03-12 14:08:16.432798000 +1100
+++ rcorder.10.3.jm     2016-03-12 14:08:36.667104000 +1100
@@ -44,6 +44,7 @@
 /etc/rc.d/ppp
 /etc/rc.d/faith
 /etc/rc.d/routing
+/etc/rc.d/ipfw
 /etc/rc.d/netwait
 /etc/rc.d/resolv
 /etc/rc.d/local_unbound
@@ -57,7 +58,6 @@
 /etc/rc.d/mrouted
 /etc/rc.d/routed
 /etc/rc.d/defaultroute
-/etc/rc.d/ipfw
 /etc/rc.d/NETWORKING
 /etc/rc.d/mountcritremote
 /etc/rc.d/newsyslog

-- 
You are receiving this mail because:
You are the assignee for the bug.