[Bug 207854] usr/src/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.c:1437: bad shift ?

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Mar 9 19:27:30 UTC 2016


            Bug ID: 207854
           Summary: usr/src/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.
                    c:1437: bad shift ?
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

[usr/src/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.c:1437]: (error)
Shifting 32-bit value by 63 bits is undefined behaviour

Source code is

       for (tmpN=7 ; tmpN<64; tmpN++ )
            tmp = ABS((int)(slope - tmpA/(1<<tmpN)));

Maybe better code

       for (tmpN=7 ; tmpN<64; tmpN++ )
            tmp = ABS((int)(slope - tmpA / (1UL << tmpN)));

You are receiving this mail because:
You are the assignee for the bug.

More information about the freebsd-bugs mailing list