[Bug 210686] NCQ_TRIM_BROKEN quirk mismatch

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210686

            Bug ID: 210686
           Summary: NCQ_TRIM_BROKEN quirk mismatch
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: allg at ayatan.org

Created attachment 171939
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171939&action=edit
patch for ata_da.c

Crucial MX200 is not blacklisted, but NCQ_TRIM_BROKEN quirk is enabled.

> ada0 at ahcich0 bus 0 scbus0 target 0 lun 0
> ada0: <Crucial CT250MX200SSD3 MU03> ACS-3 ATA SATA 3.x device
> ada0: Serial Number xx
> ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
> ada0: Command Queueing enabled
> ada0: 238475MB (488397168 512 byte sectors)
> ada0: quirks=0x2<NCQ_TRIM_BROKEN>

Mismatched quirk entry is:

> 		/*
> 		 * Crucial M500 SSDs all other firmware
> 		 * NCQ Trim doesn't work
> 		 */
> 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M500*", "*" },
> 		/*quirks*/ADA_Q_NCQ_TRIM_BROKEN

"Crucial CT*M500*" is equivalent to "Crucial CT*".
(wildcard '*' in pattern matches rest of name (in cam.c))

I wrote a patch. This patch also includes fix for Micron M510/M550.

-- 
You are receiving this mail because:
You are the assignee for the bug.