[Bug 210658] [PATCH] usr.sbin/ppp failing to build due to missing -lcrypt since r275054

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210658

            Bug ID: 210658
           Summary: [PATCH] usr.sbin/ppp failing to build due to missing
                    -lcrypt since r275054
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch, regression
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: madpilot at FreeBSD.org
                CC: bapt at FreeBSD.org

Created attachment 171907
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171907&action=edit
worksforme patch

I'm testing building a nanoBSD image using head and it is failing to build ppp
sources with this error:

--- all_subdir_usr.sbin/ppp ---
auth.o: In function `auth_CheckPasswd':
/usr/local/nanobsd/rr-11/src/usr.sbin/ppp/auth.c:(.text+0x73e): undefined
reference to `crypt'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [ppp] Error code 1

(full log available if needed)

I've noticed that the crypt library was removed in r275054 as part of a bigger
refactor.

I don't know much of the internals of the build system but it looks to me there
was confusion between crypt and crypto in this commit and crypt was removed by
mistake. The build usually works for a whole tree, but excluding bits like I'm
doing with nanoBSD exposes the problem.

Attaching a simple "works for me" patch which adds -lcrypt back to the linker
command line.

CCing bapt as the author of the commit which seems to cause the problem. If my
analysis is wrong, please accept my excuses.

-- 
You are receiving this mail because:
You are the assignee for the bug.