[Bug 210319] sys/cpuset.h should not (unconditionally) include sys/queue.h

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210319

            Bug ID: 210319
           Summary: sys/cpuset.h should not (unconditionally) include
                    sys/queue.h
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: knu at FreeBSD.org

Created attachment 171481
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171481&action=edit
A patch for sys/sys/cpuset.h

sys/cpuset.h is included by pthread_np.h, which is included by user
applications.

sys/queue.h defines a lot of macros that should only be exposed to kernel
sources, so the #include directive should be guarded with #ifdef _KERNEL, or
just removed if all users are naturally expected to include sys/queue.h.

Ruby fails to build on 11-CURRENT due to a macro name clash of LIST_HEAD()
between FreeBSD's sys/queue.h and CCAN's list module.

http://beefy4.nyi.freebsd.org/data/head-amd64-default/p414752_s299210/logs/ruby23-2.3.1,1.log

The #include directive was added in r299122, but I suspect the line was
irrelevant to the rest of the commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.