[Bug 195929] usr.bin/sed -- constify, remove line-length limits

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jul 12 05:26:33 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195929

Mikhail Teterin <mi at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172273|0                           |1
        is obsolete|                            |

--- Comment #20 from Mikhail Teterin <mi at FreeBSD.org> ---
Created attachment 172402
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172402&action=edit
Add come more const

(In reply to Pedro F. Giffuni from comment #19)
> Please review this update.

Seems fine... I added some more const-poison, though -- this time to the
regex_t-pointers.

> /usr/src/usr.bin/sed/compile.c:913:28: warning: cast from 'const char *' to
>      'unsigned char *' drops const qualifier [-Wcast-qual]

Fixed -- by adding const to casting (and p's declaration) as well.

It now compiles cleanly here with clang-3.4.1 (base), as well as clang-3.8.0
and gcc-6.0. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list