[Bug 210865] bsdinstall: install faill with ZFSBOOT_DATASETS=da0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210865

            Bug ID: 210865
           Summary: bsdinstall: install faill with ZFSBOOT_DATASETS=da0
           Product: Base System
           Version: 10.3-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: h-fujishima at sakura.ad.jp

When the preamble contain the variable ZFSBOOT_DATASETS install process fail.
Because $TMP_FSTAB of bsdinstall/umount is empty.

```
--- FreeBSD-10.3-RELEASE-amd64-disc1/usr/libexec/bsdinstall/umount.orig
2016-03-25 11:14:43.000000000 +0900
+++ FreeBSD-10.3-RELEASE-amd64-disc1/usr/libexec/bsdinstall/umount     
2016-07-06 12:39:21.810951339 +0900
@@ -39,4 +39,4 @@
 }' > $TMP_FSTAB

 umount $BSDINSTALL_CHROOT/dev 2>/dev/null
-umount -F $TMP_FSTAB -a 2>/dev/null
+test -s $TMP_FSTAB && umount -F $TMP_FSTAB -a 2>/dev/null
```

FreeBSD-10.3-RELEASE-amd64-disc1/usr/libexec/bsdinstall/script
```
############################################################ FUNCTIONS

error()
{
        [ -f "$PATH_FSTAB" ] && bsdinstall umount

        local file
        f_getvar "$VAR_DEBUG_FILE#+" file
        if [ "$file" ]; then
                f_dialog_title "$msg_installation_error"
                f_dialog_textbox "$file"
                # No need to restore title, pining for the fjords
        fi

        exit 1
}

############################################################ MAIN

set -e
trap error EXIT

[...]

bsdinstall entropy
bsdinstall umount <= fail!!

f_dprintf "Installation Completed at %s" "$( date )"
```

-- 
You are receiving this mail because:
You are the assignee for the bug.