[Bug 207312] Useless check in netipsec/key.c

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Feb 19 09:26:44 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207312

--- Comment #1 from Andrey V. Elsukov <ae at FreeBSD.org> ---
(In reply to Mikhail Teterin from comment #0)
> @@ -7245,9 +7245,8 @@ key_parse(struct mbuf *m, struct socket
>         orglen = PFKEY_UNUNIT64(msg->sadb_msg_len);
>         target = KEY_SENDUP_ONE;
> 
> -       if ((m->m_flags & M_PKTHDR) == 0 ||
> -           m->m_pkthdr.len != m->m_pkthdr.len) {
> -               ipseclog((LOG_DEBUG, "%s: invalid message
> length.\n",__func__));

The log message says about invalid length, probably, comparison should be done
with orglen. I need some time to create the testing environment for this, can
you test this by self?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list