[Bug 215333] head -r310046 for powerpc family: sys/powerpc/powerpc/intr_machdep.c's i->trig == -1 if-tests reported as always false by compiler

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215333

            Bug ID: 215333
           Summary: head -r310046 for powerpc family:
                    sys/powerpc/powerpc/intr_machdep.c's i->trig == -1
                    if-tests reported as always false by compiler
           Product: Base System
           Version: CURRENT
          Hardware: powerpc
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: markmi at dsl-only.net

--- intr_machdep.o ---
/usr/src/sys/powerpc/powerpc/intr_machdep.c:454:15: warning: comparison of
constant -1 with expression of type 'enum intr_trigger' is always false
[-Wtautological-constant-out-of-range-compare]
              if (i->trig == -1)
                  ~~~~~~~ ^  ~~
/usr/src/sys/powerpc/powerpc/intr_machdep.c:500:16: warning: comparison of
constant -1 with expression of type 'enum intr_trigger' is always false
[-Wtautological-constant-out-of-range-compare]
                      if (i->trig == -1)
                          ~~~~~~~ ^  ~~

Justin Hibbits wrote about the note that I sent him that listed the above:

This may or may not be a problem, depending on optimization settings.  Can you
file a bug for this so it doesn't get lost?


I also noted:

There are other comparisons around with a constant
result at compile time. But they tend to be in less
central areas like zfs. Similarly for some other
types of compiler reports.

-- 
You are receiving this mail because:
You are the assignee for the bug.