[Bug 215105] link_aton() hex formatting breakage in today's patch

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215105

            Bug ID: 215105
           Summary: link_aton() hex formatting breakage in today's patch
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: jtd2004a at sbcglobal.net

The recently issued patch for security issue FreeBSD-SA-16:36.libc has three
problems affecting the link_ntoa() function.

1. Hex digits are reversed in order: 0x27 is represented as 72, etc.  This is
because the old code wrote out[1] then out[0]; the new code writes *out++ and
*out++ in the same order.
2. Accounting of buffer space is bad: In the single-digit case, it has 'rem++'
but should probably have 'rem--' instead.
3. Bytes in the range 0x80-0xff are represented badly, for instance 0x84 is
represented by backslash in my test environment.  This appears to result from
'char' and 'int' being signed, in the 'if (i > 0xf)'.  This one might also
depend on my very unusual system.

-- 
You are receiving this mail because:
You are the assignee for the bug.