[Bug 211965] [patch] fmodl not properly aliased on architectures where LDBL_PREC == 53 (arm, mips, powerpc)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Aug 30 20:50:56 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211965

Kyle Evans <bsdports at kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173822|0                           |1
        is obsolete|                            |

--- Comment #1 from Kyle Evans <bsdports at kyle-evans.net> ---
Created attachment 174233
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=174233&action=edit
svn(1) diff of lib/msun/src, standardizing conditionals and properly aliasing
fmodl

As mentioned by Warner Losh [1], LDBL_MANT_DIG == 53 could be written as
LDBL_MANT_DIG == DBL_MANT_DIG to better convey the intention of this block.

I've amended this to do that, as well as to give the same treatment to the
other instances where the same meaning is intended. Also, I've standardized all
of these to a form without parentheses enclosing the statement.

This could presumably be split out into a patch solely addressing the aliasing
of fmodl and a patch addressing the consistency nits, but this is trivial
enough that I left it alone.

[1] https://lists.freebsd.org/pipermail/freebsd-arm/2016-August/014604.html

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list