[Bug 211958] Boot overflows when reading loader.conf

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Aug 18 07:56:56 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211958

            Bug ID: 211958
           Summary: Boot overflows when reading loader.conf
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: ecturt at gmail.com

There are some overflows when reading loader.conf, for example if you add a
line like:

autoboot aaaaaaaaa...

It will overflow a 256 byte buffer here:

https://github.com/freebsd/freebsd/blob/af3e10e5a78d3af8cef6088748978c6c612757f0/sys/boot/common/boot.c#L132

https://github.com/freebsd/freebsd/blob/7fc7d2ed6e06340ab861cd094a78db87215ecff3/sys/boot/common/commands.c#L36

This sprintf pattern into command_errbuf seems to be repeated a lot, and should
probably be replaced with slprintf.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list