[Bug 204005] [patch][pf] PF_ANEQ macro improperly compare IPv4 packets.

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Aug 17 15:15:07 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204005

--- Comment #3 from commit-hook at freebsd.org ---
A commit references this bug:

Author: kp
Date: Wed Aug 17 15:14:21 UTC 2016
New revision: 304293
URL: https://svnweb.freebsd.org/changeset/base/304293

Log:
  MFC r289932, r289940:

  PF_ANEQ() macro will in most situations returns TRUE comparing two identical
  IPv4 packets (when it should return FALSE). It happens because PF_ANEQ()
doesn't
  stop if first 32 bits of IPv4 packets are equal and starts to check next 3*32
  bits (like for IPv6 packet). Those bits containt some garbage and in result
  PF_ANEQ() wrongly returns TRUE.

  Fix: Check if packet is of AF_INET type and if it is then compare only first
32
  bits of data.

  PR:             204005
  Submitted by:   Mi?osz Kaniewski

Changes:
_U  stable/10/
  stable/10/sys/net/pfvar.h

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list