[Bug 208464] [svr4] svr4.ko fails to load due to not finding symbol svr4_delete_socket even though it is present in same module

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208464

--- Comment #2 from Kristoffer Eriksson <ske-89 at pkmab.se> ---
Created attachment 169113
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=169113&action=edit
Patch for incomplete ifdefs for SYSVMSG/SEM/SHM in svr4.ko preventing separate
compilation of the module

Compiling the svr4.ko module in isolation for the svr4_delete_socket bug, I
ended up getting complaints from kldload about undefined symbols
svr4_sys_msgsys, svr4_sys_semsys, svr4_sys_shmsys.

When running make in sys/modules/svr4/ separately with no parameters, the
defines SYSVMSG, SYSVSEM, SYSVSHM are not defined. Code in
sys/compat/svr4/svr4_ipc.c #ifdef these, and exclude code for the calls
mentioned above when not defined. But the file syscalls.master still referred
to them unconditionally, causing the loader to try to find them, but failing.

I added matching #ifdefs to syscalls.master. That fixed it.

I guess this has no effect in the release version, where this calls are not
excluded.

-- 
You are receiving this mail because:
You are the assignee for the bug.