[Bug 207786] gpioiic_callback() dereferences IIC "how" argument incorrectly
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Tue Apr 5 23:21:32 UTC 2016
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207786
--- Comment #2 from chadf at triularity.org ---
When will anyone ever pass an address that isn't memory aligned _and_ using the
interface correctly? Any code calling that which doesn't pass the address of an
int (which should be aligned automatically) should be fixed instead of trying
to work around it here.
The only place in the sys code that seems to initiate such a callback (for
IIC_REQUEST_BUS) is iicbus_request_bus() [sys/dev/iicbus/iiconf.c], which
passes the address of an int parameter that is expected to already be aligned.
The function lpbb_callback() [sys/dev/ppbus/lpbb.c] already handles this
properly, presumable without any alignment problems.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-bugs
mailing list